Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call complete when revoking all access succeeds #1214

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Call complete when revoking all access succeeds #1214

merged 1 commit into from
Oct 20, 2023

Conversation

michaeljcollinsuk
Copy link
Contributor

📝 Summary

This PR fixes a bug that meant the revoke all access task was not marked as completed in the DB.

🔍 What should the reviewer concentrate on?

  • Code change/test change

🧑‍💻 How should the reviewer test these changes?

  • Soft delete an s3 bucket, then check the /tasks page - the task to revoke all access should not appear

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

Gary-H9
Gary-H9 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk merged commit bb90837 into main Oct 20, 2023
4 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the bugfix/DPAT-1749 branch October 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

@ymao2 ymao2 Awaiting requested review from ymao2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljcollinsuk @Gary-H9