Bugfix/allow app registration #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update rules to allow app admin to create Auth0 clients - Display the Webapps nav button to all users, so they have access to the register app button
Updates the register app form, so that users cannot grant apps access to datasources they dont have admin access for. Add unit test and update other tests that require a user object
On manage app page, only display datasources that the app admin already has access to. Also limit only to non-data warehouses. Superusers can see all buckets.
Add method to user to check if they are an app admin, and if so display the webapp data button
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on changes to #1228
Fixes some bugs found when testing:
TODO
In a follow up PR need to add in some extra tests to the new methods on the forms