Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and Python version to 3.12 #1249

Closed
wants to merge 64 commits into from

Conversation

jamesstottmoj
Copy link
Contributor

@jamesstottmoj jamesstottmoj commented Feb 14, 2024

Merging this PR will update the control panel to run on Python 3.12

📝 Summary

This PR resolves

This PR bumps several dependencies and fixes issues in the tests so that the control panel can run against Python 3.12

The changes in this PR are needed because it updates dependencies and core Python version

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Run locally. There should be no noticeable difference between main and this branch

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

requirements.txt Outdated Show resolved Hide resolved
@michaeljcollinsuk
Copy link
Contributor

michaeljcollinsuk commented Feb 15, 2024

Really good start on this. The Dockerfile will need updating as part of this so that it builds an image using python 3.11, which may go some way to resolving the current fail in CI. I wonder what else we may also need to update in the Dockerfile, there may be implications for helm version it installs, something we can discuss with the wider team.

Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk
Copy link
Contributor

Closing as replaced by #1285

@jamesstottmoj jamesstottmoj deleted the python-311-test branch April 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants