Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vscode tool add #1256

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Feature/vscode tool add #1256

merged 5 commits into from
Feb 26, 2024

Conversation

jamesstottmoj
Copy link
Contributor

Merging this PR will add VSCode as an additional Analytical Tool

📝 Summary

The following PR adds the ability to specify VSCode as a useable IDE, as well as specify VSCode in the create new tool release form.
The changes in this PR are needed because it adds VSCode as an option in the Analytical Tooling list

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Add VSCode as a new tool release via the Create new tool release form
  • Add a block similar to the following in ~/Library/Caches/helm/repository/mojanalytics-index.yaml
vscode:
  - apiVersion: v1
    appVersion: 'VSCode: 1.0.0'
    created: "2024-02-05T11:11:33.698997588Z"
    description: Visual Studio Code with Auth0 authentication proxy
    digest: 2a5a3c7106bc4549aaac1fb1ed1d901b3ba45253f8fa74a37f3f999588e1e004
    icon: https://avatars3.githubusercontent.com/u/8361145?s=200&v=4?sanitize=true
    maintainers:
    - name: ministryofjustice
    name: vscode
    urls:
    - http://moj-analytics-helm-repo.s3-website-eu-west-1.amazonaws.com/vscode-1.0.0.tgz
    version: 1.0.0
  • Check the analytical tools page and see if Visual Studio Code is an option

📚 Documentation status

  • No changes to the documentation are required

@jamesstottmoj jamesstottmoj marked this pull request as ready for review February 26, 2024 15:54
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljcollinsuk michaeljcollinsuk merged commit ae10b72 into main Feb 26, 2024
5 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the feature/vscode-tool-add branch February 26, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants