Bugfix/namespace length #1257
Merged
Bugfix/namespace length #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used to store the Cloud Platform namespace name. Adds migrations that add the field, then a data migration to add values for existing apps, then finally a third migration to require values when creating a new object.
Adds the field in the HTML. Update the OIDC template to use the entered namespace when creating the app IAM role.
Updates the create app role task handler to pass a github api token, so this can be used to create the APP_ROLE_ARN secret as soon as the App role is created. This is required for apps that will be deployed without Auth0 clients.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR resolves a bug where our expected namespace is too long to be valid for Cloud Platform
Instead of assuming the namespace to be in the format of
data-platform-app-<repo-name>, the user will enter their chosen namespace. This is then used when we create the trust policy for the App iam role.The namespace will be stored on the model. For all existing apps, there is a data migration to add these.
Merging this PR will have the following side-effects:
data-platform-appprefix, others will not🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
📚 Documentation status