Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 Update VS Code tool domain #1260

Merged
merged 4 commits into from
Feb 26, 2024
Merged

🚑 Update VS Code tool domain #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6591be
Update VS Code tool domain
Feb 26, 2024
24dd5bf
Fix my errors
Feb 26, 2024
801405b
Update release-create.html
Feb 26, 2024
eddc723
Update release-detail.html
Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controlpanel/frontend/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ def clean_tool_domain(self):
"airflow-sqlite",
"jupyter-lab",
"rstudio",
"visual-studio-code"
"vscode"
]
value = self.cleaned_data.get("tool_domain")
if value and value not in valid_names:
Expand Down
2 changes: 1 addition & 1 deletion controlpanel/frontend/jinja2/release-create.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ <h1 class="govuk-heading-xl">{{ page_title }}</h1>
},
"classes": "govuk-!-width-two-thirds",
"hint": {
"text": 'If the chart name is non-standard, use this value in the domain name for the tool. Use only one of: airflow-sqlite, jupyter-lab, rstudio or visual-studio-code.'
"text": 'If the chart name is non-standard, use this value in the domain name for the tool. Use only one of: airflow-sqlite, jupyter-lab, rstudio or vscode.'
},
"name": "tool_domain",
"attributes": {
Expand Down
2 changes: 1 addition & 1 deletion controlpanel/frontend/jinja2/release-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ <h1 class="govuk-heading-xl">{{ page_title }}</h1>
},
"classes": "govuk-!-width-two-thirds",
"hint": {
"text": 'If the chart name is non-standard, use this value in the domain name for the tool. Use only one of: airflow-sqlite, jupyter-lab, rstudio or visual-studio-code.'
"text": 'If the chart name is non-standard, use this value in the domain name for the tool. Use only one of: airflow-sqlite, jupyter-lab, rstudio or vscode.'
},
"name": "tool_domain",
"attributes": {
Expand Down
2 changes: 1 addition & 1 deletion tests/frontend/test_forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def test_tool_release_form_check_tool_domain():
"version": "1.2.3",
"values": {"foo": "bar"},
"is_restricted": False,
"tool_domain": "visual-studio-code",
"tool_domain": "vscode",
}
f = forms.ToolReleaseForm(data)
assert f.is_valid()
Expand Down
Loading