Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable app registration #1261

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Enable app registration #1261

merged 2 commits into from
Mar 18, 2024

Conversation

michaeljcollinsuk
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk commented Feb 29, 2024 •
edited
Loading

📝 Summary

This PR re-enables the app registration button

🔍 What should the reviewer concentrate on?

  • Code changes

🧑‍💻 How should the reviewer test these changes?

  • The button was already enabled for superusers, to test the user would need to be logged in to the control panel as a normal user and visit the webapp list page - at the bottom the "Register an app" button should now be displayed.

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

@michaeljcollinsuk michaeljcollinsuk mentioned this pull request Feb 29, 2024
Closed
5 tasks
@michaeljcollinsuk michaeljcollinsuk marked this pull request as ready for review March 18, 2024 12:08
jamesstottmoj
jamesstottmoj approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk force-pushed the enable-app-registration branch from c2a5a99 to 7005997 Compare March 18, 2024 12:20
@michaeljcollinsuk michaeljcollinsuk merged commit 937343d into main Mar 18, 2024
4 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the enable-app-registration branch March 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesstottmoj jamesstottmoj jamesstottmoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljcollinsuk @jamesstottmoj