Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions workflow to trigger build/deploy only when releases #1274

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

michaeljcollinsuk
Copy link
Contributor

📝 Summary

This PR resolves a bug where the actions workflow is triggered 3 times when a new release is created

Merging this PR will have the following side-effects:

  • There is potential that the change does not work, and the workflow does not trigger when the release is created. If this occurs, we can revert the commit

🔍 What should the reviewer concentrate on?

  • Actions file chang

🧑‍💻 How should the reviewer test these changes?

  • Create a new release, check it triggers the build and test workflow

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

Copy link
Contributor

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk merged commit dcc8412 into main Mar 22, 2024
5 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the bugfix/update-releases-trigger branch March 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants