Update justice auth flow to use client_secret and prompt login #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the client_secret created in Azure app registration, for better security. This is set as an env var, and will be read from a Kubernetes secret, which will be added manually elsewhere. Also update azure client settings to always prompt the user to complete the login process with their justice identity. This will avoid confusion if a user is already logged in to their Justice identity.
jamesstottmoj
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the client_secret created in Azure app registration, for better security. This is set as an env var, and will be read from a Kubernetes secret, which will be added manually elsewhere. Also update azure client settings to always prompt the user to complete the login process with their justice identity. This will avoid confusion if a user is already logged in to their Justice identity.
In order to run locally, a new secret
AZURE_CLIENT_SECRETneeds to be added to your .env file. This is stored in the AP 1password vault, under the name "Control Panel Azure App Client Secrets"