Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure redirect to index if no justice id regardless of route hit #1283

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

jamesstottmoj
Copy link
Contributor

@jamesstottmoj jamesstottmoj commented Apr 9, 2024

📝 Summary

This PR ensures that a user is redirected to the index page if they have not authorised with their justice identity.

The changes in this PR are needed because if the user accesses the control panel through any other route, e.g control-panel/tools, they will not see the page that allows them to log in with their justice identity

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Manually test by logging out, access the control panel by any page that isn't the root, then check that you are redirected to the page that asks for your justice credentials

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jamesstottmoj jamesstottmoj merged commit 29036d2 into main Apr 9, 2024
5 checks passed
@jamesstottmoj jamesstottmoj deleted the fix/justice-auth-redirect branch April 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants