Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage messaging about authenticating with justice identity #1286

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

michaeljcollinsuk
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk commented Apr 9, 2024

📝 Summary

Update the messaging to users about authenticating with their Justice identity. Screenshot of the page at time marked ready for review:

image

Some of the text has been taken from our comms to users via slack https://mojdt.slack.com/archives/C4PF7QAJZ/p1712592546423129

Also updates the admin so that it is easy for us to track which users have completed the authentication, by filtering on the justice_email db field.

🔍 What should the reviewer concentrate on?

  • Text changes

🧑‍💻 How should the reviewer test these changes?

  • Log in to Control Panel, you will be prompted by the page

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

@michaeljcollinsuk michaeljcollinsuk marked this pull request as ready for review April 9, 2024 15:45
jamesstottmoj
jamesstottmoj previously approved these changes Apr 9, 2024
Copy link
Contributor

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@michaeljcollinsuk michaeljcollinsuk merged commit 64da2d5 into main Apr 9, 2024
5 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the feature/justice-auth-enable-dev branch April 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants