Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/run black #1292

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Feature/run black #1292

merged 13 commits into from
Apr 23, 2024

Conversation

michaeljcollinsuk
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk commented Apr 22, 2024

📝 Summary

This PR contributes to ministryofjustice/analytical-platform#3374

Specifically it:

  • Runs black on the whole codebase to bring a consistent style across all files.
  • Add super-linter CI job. We are using this to primarily run black, flake8 and isort, however we may utilise some of the other linters in the future

🧑‍💻 How should the reviewer test these changes?

  • Pull the changes, update your dev dependencies
  • Run black . && flake8 . && isort . from your terminal to run all three checks. There should be no proposed changes
  • All checks in CI are passing

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

@michaeljcollinsuk michaeljcollinsuk marked this pull request as ready for review April 22, 2024 16:01
Copy link
Contributor

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk merged commit 5d54922 into main Apr 23, 2024
12 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the feature/run-black branch April 23, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants