Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/feedback form #1401

Merged
merged 14 commits into from
Dec 10, 2024
Merged

Feature/feedback form #1401

merged 14 commits into from
Dec 10, 2024

Conversation

jamesstottmoj
Copy link
Contributor

@jamesstottmoj jamesstottmoj commented Dec 2, 2024

📝 Summary

This PR is linked to ministryofjustice/analytical-platform#6112

This PR adds a form that allows users to give feedback on the analytical platform

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Pull down branch
  • Run sever
  • Click feedback link on banner above nav bar
  • Add feedback

📚 Documentation status

  • No changes to the documentation are required

@jamesstottmoj jamesstottmoj marked this pull request as ready for review December 5, 2024 09:03
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some very minor comments

Also I dont think it is worth adding a custom page to check the feedback, but a quick win would be to register it with the django admin - that way there is an option to check what is coming in in the brower. See docs here but can be as simple as adding the below to the api/admin.py file:

@admin.register(Feedback)
class FeedbackAdmin(admin.ModelAdmin):
    list_display = ["satisfaction_rating", "suggestions", "date_added"]

controlpanel/api/models/feedback.py Outdated Show resolved Hide resolved
controlpanel/frontend/views/feedback.py Outdated Show resolved Hide resolved
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jamesstottmoj jamesstottmoj merged commit 9715598 into main Dec 10, 2024
11 checks passed
@jamesstottmoj jamesstottmoj deleted the feature/feedback-form branch December 10, 2024 16:20
Copy link

sentry-io bot commented Dec 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NameError: name 'fos' is not defined controlpanel.settings.common in <module> View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants