Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially fixed authorisation error when upgrading kubernetes #1415

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Potentially fixed authorisation error when upgrading kubernetes #1415

merged 3 commits into from
Dec 18, 2024

Conversation

jamesstottmoj
Copy link
Contributor

📝 Summary

This PR fixes authorisation issue when upgrading Kubernetes package.

Merging this PR will have the following side-effects:

🔍 What should the reviewer concentrate on?

  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Pull down branch
  • Navigate to tool page
  • Check no issues arise accessing the page

📚 Documentation status

  • No changes to the documentation are required

michaeljcollinsuk
michaeljcollinsuk approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesstottmoj jamesstottmoj merged commit 22ea8ec into main Dec 18, 2024
11 checks passed
@jamesstottmoj jamesstottmoj deleted the test/kube-upgrade branch December 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesstottmoj @michaeljcollinsuk