Convert ToolDeployment to a django model #1423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
michaeljcollinsuk
force-pushed
the
spike/track-tool-deployment
branch
from
f92b17e to
7207e77
Compare
There was a problem hiding this comment.
Manually tested and seems to work ok.
One issue I ran into was the caching of javascript code which meant no buttons would activate on the tools page so that may be something to potentially be aware of (hard refresh gets round this).
Potential idea for making use of this data is to automatically uninstall tool releases that are marked as retired. This will force users to use the control panel to install the latest release of that tool.
Allows us to track the specific tool release that a user has deployed. This commit includes minimal changes to get the model working, so that every time a tool is deployed from the front end, a database object is created. This does introduce a bug about status of the tool deployment, but this will be fixed later.
Use an is_active field to allow us to track past deployments. This also makes it easier to uninstall an old tool before we install a new one. NB a bug will occur if a user has no active ToolDeployment but tries to switch from a jupyter datascience to all-spark release (or vice versa). To resolve, we have to manually install the users Jupyter release, or deploy the same type of Jupyter to create an "active" ToolDeployment object, and then the user can deploy the other type of Jupyter.
Deletes a lot of code that was used to display the deployed tool, to read information from the tool models where possible. Further refactoring will be needed to add a form to handle tool choices.
Simplify the logic to deploy tools based on the ID. Update ToolDeployment serializer
Loops through all namespaces, and creates a DB record to correspond with the tool that they have deployed.
michaeljcollinsuk
force-pushed
the
spike/track-tool-deployment
branch
from
9092bfa to
9a31df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to track the specific tool release that
a user has deployed.
This commit includes minimal changes to get the
model working, so that every time a tool is
deployed from the front end, a database object is
created. This does introduce a bug about status of the tool deployment, but this will be fixed later.
📝 Summary
This PR resolves ...
This PR ...
The changes in this PR are needed because ...
Merging this PR will have the following side-effects:
🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
python manage.py migratemake build-jsvaluesfield. So instead, I would suggest copying tool releases from prod/dev. If taking from prod, if you want to try accessing the tool you will need to update some of the helm values for the release, such as the auth0 domain and client ID/secret. Let me know if you need a hand with this.📚 Documentation status