Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transitionary notification redirect page for external urls #1153

Closed
wants to merge 4 commits into from

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Dec 9, 2024

PR for #1108

This is in response to some UR where users felt it was not made clear enough that certain links were taking them outside of the find moj data service.

What i've done

  • created a redirect page template
  • created a redirect view
  • changed external links in other templates to call the new view and pass the actual external link as a query parameter in the request, which then renders the redirect template which redirects

Accessibility

My initial go at this didn't play to well with assistive tech in the form of the mac's voiceover screen reader. To work around this i have made the new redirect page autofocus on the heading with the main info so that it's read out first and added additional info around where the user is being directed to, to the aria-label.

And on the subject of accessibility i spotted a mistake that had slipped through where our links on some pages didn't include (opens in new tab) in the link text. I have fixed that issue as part of this PR too.

@LavMatt LavMatt force-pushed the fmd-1108-you-are-leaving branch from ce31c2e to 40b2895 Compare December 9, 2024 15:54
@LavMatt LavMatt marked this pull request as ready for review December 9, 2024 16:08
@LavMatt LavMatt requested a review from a team as a code owner December 9, 2024 16:08
Copy link

@joe-horton-moj joe-horton-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the slack thread, my initial thought is that this solution could make the user experience more tedious and ultimately won't solve the core issue.

As I understand correctly, we had a few users notice that they weren't on "Find MoJ data" anymore after clicking on certain external links and were left confused wondering where they were, not noticing they were on a different GOV service.

This feels like a symptom of a wider issue (touched on in the thread) about the similarity in look and feel of GOV services and the difficulty to distinguish the service from initial glance.

My opinion at this stage would be park the bus on implementing anything and continue to monitor the issue in future UR sessions.

If we find the issue coming up again, I'd recommend two different options:

  1. design and test a different styling / interaction of our external links
  2. developing a stronger brand identity or look and feel for "Find MoJ data"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants