Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urlencode entity url for notifications #1173

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

mitchdawson1982
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 commented Dec 13, 2024

  • Adds encoded_entity_url method to the Issue model that returns a url encoded entity url, and associated test. This resolves the issue with the notify templates incorrect rendering urls with ) within them.

@mitchdawson1982 mitchdawson1982 force-pushed the urlencode-entity-url branch 2 times, most recently from a5c5de7 to e948e2a Compare December 13, 2024 20:35
@mitchdawson1982 mitchdawson1982 force-pushed the urlencode-entity-url branch 3 times, most recently from 249e031 to ebeb7d5 Compare December 16, 2024 10:23
@mitchdawson1982 mitchdawson1982 marked this pull request as ready for review December 16, 2024 10:27
@mitchdawson1982 mitchdawson1982 requested a review from a team as a code owner December 16, 2024 10:27
feedback/models.py Show resolved Hide resolved
@mitchdawson1982 mitchdawson1982 merged commit e49d450 into main Dec 17, 2024
10 checks passed
@mitchdawson1982 mitchdawson1982 deleted the urlencode-entity-url branch December 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants