-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tags to populate subject areas #1233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subject area labels were previously populated from the domain in Datahub. This now comes from a tag. Where there are multiple tags, pick the first one for now. In a future commit, I'll enable multiple subject areas to be displayed.
MatMoore
force-pushed
the
fetch-subject-areas-via-tags
branch
from
January 14, 2025 16:10
459458b
to
0866be3
Compare
murdo-moj
reviewed
Jan 15, 2025
murdo-moj
reviewed
Jan 15, 2025
murdo-moj
reviewed
Jan 15, 2025
murdo-moj
reviewed
Jan 15, 2025
murdo-moj
reviewed
Jan 15, 2025
Co-authored-by: Murdo <[email protected]>
Co-authored-by: Murdo <[email protected]>
hjribeiro-moj
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the ingestion code is setting tags in DataHub for the subject areas, we can start to use these for search/browse instead of the DataHub domain.
This work will allow us to assign entities to more than one subject area, so we don't need to worry about something not precisely fitting into a single category when redefining the taxonomy.
Known issues
I've used the test environment for testing this since we've had some OpenSearch issues on the dev environment. When I compared before and after I noticed a few discrepancies, but the number of entities in each subject area is almost the same.
It seems like the discrepancies are due to two things, neither of which seem like blockers:
Next steps
home
app in Find MoJ data as well, e.g. some remaining references to "domains" that can be cleaned up.