Search benchmark #362
Merged
Search benchmark #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that simple queries return the expected result in position 1. This establishes the baseline behaviour that users should be able to retrieve datasets by searching for their title. These tests are skipped in CI for now.
MatMoore
force-pushed
the
search-benchmark
branch
from
5045001 to
9c24336
Compare
LavMatt
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a benchmark we can run against a running environment to check that search is working as we expect.
#357
The first test checks searching for a few datasets by title, including some with underscores (see #324)
The second test checks for duplicate results with the same title. This does not yet pass, but we can enable it when we've sorted out the CaDeT ingestion.
To run:
pytest tests/benchmarks