Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalogue unavilable page #368

Merged
merged 2 commits into from
May 28, 2024
Merged

Catalogue unavilable page #368

merged 2 commits into from
May 28, 2024

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented May 23, 2024

#210

Add some middleware so we can show a more specific error when Datahub goes down.

Copy link

sentry-io bot commented May 23, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/datahub-client/data_platform_catalogue/client/datahub_client.py

Function Unhandled Issue
__init__ ConfigurationError: Unable to connect to https://datahub-catalogue-test.apps.live.cloud-platform.service.justice.gov.... ...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

@MatMoore MatMoore force-pushed the catalog-unavilable-page branch from 3bc425b to 997f87d Compare May 23, 2024 14:28
@MatMoore MatMoore marked this pull request as ready for review May 23, 2024 14:32
@MatMoore MatMoore changed the title Catalog unavilable page Catalogue unavilable page May 23, 2024
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatMoore MatMoore merged commit 9247ad1 into main May 28, 2024
6 checks passed
@MatMoore MatMoore deleted the catalog-unavilable-page branch May 28, 2024 09:34
Copy link

sentry-io bot commented Jun 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants