Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline GitHub Actions workflows #532

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Streamline GitHub Actions workflows #532

merged 7 commits into from
Jul 12, 2024

Conversation

tom-webber
Copy link
Contributor

@tom-webber tom-webber commented Jul 11, 2024 •
edited
Loading

What's changed

This PR refactors our 'deploy' and 'test' workflows with the aim of:

  • clearer workflow names and filenames
  • reusing code testing workflows
  • dev deployments being managed from within PRs
  • deployments to test env from branch (workflow_dispatch) without deployment gating
  • the staged deploy workflow is triggered on publishing a release rather than a push to main

The PR also:

  • adds a workflow for slack alerts when the staged deploy or deploy-to-test workflows fail
  • adds code tests for staged deployment
  • removes deployment to dev during the staged deployment flow
  • a checkbox for running code tests during the deploy-to-test workflow.
  • Splits build and deploy jobs in the reusable build-and-deploy workflow

@tom-webber
update test and deployment workflows
16e9589 
- add deploy-test-from-branch with optional code-tests (workflow_dispatch)
- staged deploy reworked to trigger on release; include code tests; doesn't deploy dev
- add workflow to deploy to dev from PR or workflow_dispatch
- added reusable test workflow
- split jobs in reusable deploy workflow
@tom-webber tom-webber requested a review from a team as a code owner July 11, 2024 16:09
@tom-webber tom-webber linked an issue Jul 11, 2024 that may be closed by this pull request
⚙ Streamline github actions workflows #498
Closed
3 tasks
mitchdawson1982
mitchdawson1982 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-webber tom-webber merged commit 3682cf9 into main Jul 12, 2024
5 of 6 checks passed
@tom-webber tom-webber deleted the fmd-498-streamline-gha-workflows branch July 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdawson1982 mitchdawson1982 mitchdawson1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚙ Streamline github actions workflows
2 participants
@tom-webber @mitchdawson1982