This repository has been archived by the owner on May 5, 2020. It is now read-only.
Remove duplicated name input field html expectation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method to generate expected html output for a name input field. Replace duplicated name input field html expectations in the form builder spec with calls to the method. Change parameters to change the expected html in the small number of places it varies. This approach keep the html expectation as html text. The intention is to make it easy for developers doing frontend to see the generated markup in the test expectation. Some duplication in test expectations is acceptable when it leads to expectations that are concise and easy to read and reason about. An alternate pull request to remove this duplication created a FormGroupObject model to perform tests. This different approach lost having the expected html output easily readable in a few lines of code.
aliuk2012
approved these changes
Nov 29, 2016
|
@ministryofjustice/ruby need some reviews. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to generate expected html output for a name input field.
Replace duplicated name input field html expectations in the form builder spec with calls to the method. Change parameters to change the expected html in the small number of places it varies.
This approach keeps the html expectation as html text. The intention is to make it easy for developers doing frontend to see the generated markup in the test expectation. It allows you to quickly compare against example markup from the form section of the GOV.UK elements guide.
Some duplication in test expectations is acceptable when it leads to expectations that are concise and easy to read and reason about.
An alternate pull request #69 to remove this duplication created a FormGroupObject model to perform tests. This different approach lost having the expected html output easily readable in a few lines of code.