Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement request page - add blue banner #2271

Merged

Conversation

gregkhawkins
Copy link
Contributor

Context

JIRA: https://dsdmoj.atlassian.net/browse/APS-1690

Changes in this PR

  • On the Placement request page, add the blue banner at the top (inc. key-person details)
  • Check that this is included in the integration tests

Screenshots of UI changes

Before

before

After

after

@aliuk2012
Copy link
Contributor

aliuk2012 commented Dec 31, 2024

On CAS-3 when we rolled out the blue banner, I raised the concerns of banner blindness which I think is also relevant for CAS-1 designs

image

After speaking with @devansXD and Mahesh, we agreed to move the phase banner to the bottom of the page just above the footer. You might want to do the same in CAS-1 so that its consistent across CAS

Example of desktop and mobile
image
image

Copy link
Contributor

@froddd froddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gregkhawkins gregkhawkins force-pushed the feature/APS-1690__placement_request_page_add_blue_banner branch from 7252547 to c7f370a Compare January 7, 2025 10:51
@gregkhawkins gregkhawkins merged commit a9a7191 into main Jan 7, 2025
7 checks passed
@gregkhawkins gregkhawkins deleted the feature/APS-1690__placement_request_page_add_blue_banner branch January 7, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants