-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIT-1016 Update share image based on the custom code #23
Merged
shazChaudhry
merged 3 commits into
main
from
NIT-1016-alfresco-customization-of-share-container-image
Jan 18, 2024
Merged
NIT-1016 Update share image based on the custom code #23
shazChaudhry
merged 3 commits into
main
from
NIT-1016-alfresco-customization-of-share-container-image
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-j-g
approved these changes
Jan 18, 2024
shazChaudhry
deleted the
NIT-1016-alfresco-customization-of-share-container-image
branch
January 18, 2024 09:32
georgepstaylor
pushed a commit
that referenced
this pull request
Aug 21, 2024
* NIT-1016 Update share image based on the custom code
georgepstaylor
added a commit
that referenced
this pull request
Aug 21, 2024
* NIT-880 deploy only transform and needed dependencies * NIT-934 deploying content services in cloud platform * NIT-934 deploying content services in cloud platform * NIT-934 deploying content services in cloud platform * NIT-934 deploying content services in cloud platform * NIT-934 deploying content services in cloud platform * NIT-935 deploying share service in cloud platform * NIT-935 deploying share service in cloud platform * NIT-953 using external hostname for the share component * NIT-948 base64 encoded secret instead of plain text for solr/repo communication * NIT-938 deleted charts subdirectories that were not needed * NIT-938 deleted charts subdirectories that were not needed * NIT-938 deleted charts subdirectories that were not needed * NIT-938 Instuctions added on how to modify and publish a chart to github pages * NIT-948 Updagetd readme for shared secret extraction * Update README.md * NIT-938 Updagetd readme for shared secret extraction * NIT-938 update the readme for starting services * NIT-952 initial workflow version * NIT-952 point at share dockerfile * NIT-952 replace share image repository * NIT-979 Config updated to ensure redeployed services do restart * NIT-969 Ensuring s3 directory structure is correct * NIT-990 Using updated action variables and secrets * NIT-990 Using a new container tag that resulted from updating action variables and secrets * NIT-990 Using pipeline generated image * NIT-990 Updated number of replicas for each service as advised by ALF dev team * NIT-989 use alf license provided through a secret * NIT-966 use namespace name to build service url/hostname * NIT-994 pipeline for installing helm charts (#20) * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 pipeline for installing helm charts * NIT-994 Adding matrix strategy * NIT-994 Adding matrix strategy * NIT-994 Adding matrix strategy * NIT-994 Adding matrix strategy * NIT-994 Adding matrix strategy * NIT-994 Adding matrix strategy * NIT-994 Adding matrix strategy * Nit 1015 alfresco move existing share gh workflow to dev repo (#22) * NIT-1015 Share GH workflow to move to hmpps-alfresco repo * NIT-1015 Share GH workflow to move to hmpps-alfresco repo * NIT-1017 disable activiti engine as its not in use * NIT-1016 Update share image based on the custom code (#23) * NIT-1016 Update share image based on the custom code * NIT-1046 allow the pipeline to modify the dev namespace * NIT-1097 limit access to alfresco envs * NIT-1151 test env added in pipeline matrix deployments * NIT-1151 updating whitelist for test env * NIT-1151 allow internet traffic from cp * NIT-1098 update names for consistency * NIT-1098 add refresh jobs and workflow * NIT-1098 remove forgotten debug options * NIT-1178 increase size of ephemeral volume in test * NIT-1178 update defaults to prevent uncontrolled restarts * NIT-1178 align resource limit closer to alfresco recommendations * NIT-1170 increase number of repository pods in poc and dev * NIT-1170 increase number of repository pods in test * NIT-1170 temporarily disable poc deployments * NIT-1098 dump and restore db in parallel * Increase repository and tika resource limits in test * NIT-1181 adding security context to pods for fixing warnings * NIT-1181 remove comment * NIT-1193 enable prop db table cleaner v2 * NIT-1169 data refresh process improvements * NIT-1169 temporary data migration helpers * NIT-1169 correct descriptions * trigger release only on relevant code changes * NIT-1120 k8s job to restore docs worker * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1120 updating workflow * NIT-1231 initial config for live-like environments * NIT-1120 using simple exec to run scripts instead of creating a job * NIT-1120 using simple exec to run scripts instead of creating a job * NIT-1120 using simple exec to run scripts instead of creating a job * NIT-1120 using simple exec to run scripts instead of creating a job * NIT-1120 using simple exec to run scripts instead of creating a job * NIT-1120 extract versionId from delete markers after enabling versioning * new alf release on poc * optimise test requests and limits * add workflow * untar chart * NIT-1255 use Xms/Xmx for JVM memory allocations * NIT-1255 set JVM memory values for stage * Update helm-release.yml * helm-dependencies * unarchive * Update helm-release.yml * Update helm-release.yml * 🎉 Initial workflow for snapshot creation * Delete create-pv-restore-point.yml * compress files to a tar.gz and copy to dedicated bucket * correct s3 bucket secret key * remove yaml loop * 🔥 Remove solr backup job * NIT-1253 add workflow to make Alf env read-only * NIT-1229 workflows to scale up and down lower envs * NIT-1229 workflows to scale up and down lower envs * NIT-1253 change to kubectl annotate method instead of Helm upgrade * typo * Workflow name typo * Update create-rds-snapshot.yml * Update create-rds-snapshot.yml * Update create-rds-snapshot.yml * Update create-rds-snapshot.yml * Update create-rds-snapshot.yml * Update create-rds-snapshot.yml * NIT-1253 final revision * NIT-1253 don't hardcode namespace * NIT-1253 implement removal option * NIT-1253 add validation to ensure new snippet isn't added multipe times * Give share ingress unique hostname and cert * NIT-1229 fetching values from helm release * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 change to manual run for testing and using json format * NIT-1229 changing back to scheduled run * NIT-1229 workflow to run on weekdays only * NIT-1256 run long running jobs on runners available in org * NIT-1279 testing recovery process * NIT-1279 testing recovery process * NIT-1279 restore status check and increase in wait time * NIT-1279 restore status check and increase in wait time * NIT-1279 passing env variables explicitly * NIT-1279 check for when deleted marker is not available * NIT-1279 check for when deleted marker is not available * NIT-1279 swithing off debug mode and change in exit code * NIT-1298 adding dev to autoscaling matrix * NIT-1305 diff scale time for dev * NIT-1305 dev to scale up at diff times * NIT-1305 dev to scale up at diff times * NIT-1305 adding a reusable workflow for scaling up * NIT-1305 fix error in script * chore: Add templated directory to .gitignore and update IP whitelist in values files * Update cloud-platform-deploy-release.yml * remove share subdomain * redirect to /share * NIT-1425 fix typo for workflow * ✨ Update DB Refresh workflow to include Slack notifications (#76) * ✨ Update DB Refresh workflow to include Slack notifications * 🐛 poc now uses opensearch * Update data-refresh.yaml * --ignore-not-found for helm uninstall * Happy Helming * Update data-refresh.yaml * 🐛 Correct service account names for refresh jobs * fix: Add curl package and fix Slack message * typo * ✨ create image and update job Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update Dockerfile Update job.yaml Update Dockerfile Update Dockerfile Update job.yaml absolute dirs Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update Dockerfile non root support Update job.yaml Update data-refresh.yaml up Update build-push-db-utils.yml rename Update build-push-db-utils.yml Update build-push-db-utils.yml no need to install jq no password update jobs for refresh * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * t * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * typo * Update job.yaml * Update job.yaml * Update data-refresh.yaml --------- Co-authored-by: George Taylor <[email protected]> * ✨ Update DB Refresh workflow to include Slack notifications * ✨ Update DB Refresh workflow to include Slack notifications * 🐛 poc now uses opensearch * Update data-refresh.yaml * --ignore-not-found for helm uninstall * Happy Helming * Update data-refresh.yaml * 🐛 Correct service account names for refresh jobs * fix: Add curl package and fix Slack message * typo * ✨ create image and update job Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update Dockerfile Update job.yaml Update Dockerfile Update Dockerfile Update job.yaml absolute dirs Update job.yaml Update job.yaml Update job.yaml Update job.yaml Update Dockerfile non root support Update job.yaml Update data-refresh.yaml up Update build-push-db-utils.yml rename Update build-push-db-utils.yml Update build-push-db-utils.yml no need to install jq no password update jobs for refresh * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * t * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * Update job.yaml * typo * Update job.yaml * Update job.yaml * Update data-refresh.yaml --------- Co-Authored-By: George Taylor <[email protected]> * ✨ Helm chart configuration for Opensearch and enterprise search connector (#70) * update values for opensearch * add makefile +chart changes * Update values.yaml * Update values.yaml * update makefile * Update values.yaml * Update values.yaml * Update values.yaml * vars * Update values.yaml * Update values.yaml * images * config map * Revert "config map" This reverts commit e714ada. * Reapply "config map" This reverts commit c47acb8. * config map * images * Squashed commit of the following: commit 6cda4f5 Merge: a682b79 ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 15:03:01 2024 +0100 Merge pull request #75 from ministryofjustice/fix-ingress-share-real Revert share ingress to dedicated hostname + enable redirect to /share commit ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 13:15:37 2024 +0100 redirect to /share commit a682b79 Merge: 066cecc 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:23:05 2024 +0100 Merge pull request #74 from ministryofjustice/remove-share-sub-domain Remove share subdomain commit 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:21:18 2024 +0100 remove share subdomain commit 066cecc Merge: 4d23e4b b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:36:49 2024 +0100 Merge pull request #73 from ministryofjustice/workflow-changes Update cloud-platform-deploy-release.yml commit b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:35:57 2024 +0100 Update cloud-platform-deploy-release.yml commit 4d23e4b Merge: 6aeb967 ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:09:57 2024 +0100 Merge pull request #72 from ministryofjustice/add-airflow-ips chore: Add templated directory to .gitignore and update IP whitelist in values files commit ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:08:14 2024 +0100 chore: Add templated directory to .gitignore and update IP whitelist in values files commit 6aeb967 Merge: f6a7c0e 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:10:27 2024 +0100 Merge pull request #71 from ministryofjustice/NIT-1305-custom-scaling-times NIT-1305 fix error in script commit 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:03:12 2024 +0100 NIT-1305 fix error in script * Update ingress-share.yaml * Use multi live indexing vals indexing Update values.yaml Update liveindexing-deployment.yaml Update values.yaml * ♻️ NIT 1402 alfresco use stock helm chart (#81) * update values for opensearch * add makefile +chart changes * Update values.yaml * Update values.yaml * update makefile * Update values.yaml * Update values.yaml * Update values.yaml * vars * Update values.yaml * Update values.yaml * images * config map * Revert "config map" This reverts commit e714ada. * Reapply "config map" This reverts commit c47acb8. * config map * images * Squashed commit of the following: commit 6cda4f5 Merge: a682b79 ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 15:03:01 2024 +0100 Merge pull request #75 from ministryofjustice/fix-ingress-share-real Revert share ingress to dedicated hostname + enable redirect to /share commit ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 13:15:37 2024 +0100 redirect to /share commit a682b79 Merge: 066cecc 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:23:05 2024 +0100 Merge pull request #74 from ministryofjustice/remove-share-sub-domain Remove share subdomain commit 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:21:18 2024 +0100 remove share subdomain commit 066cecc Merge: 4d23e4b b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:36:49 2024 +0100 Merge pull request #73 from ministryofjustice/workflow-changes Update cloud-platform-deploy-release.yml commit b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:35:57 2024 +0100 Update cloud-platform-deploy-release.yml commit 4d23e4b Merge: 6aeb967 ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:09:57 2024 +0100 Merge pull request #72 from ministryofjustice/add-airflow-ips chore: Add templated directory to .gitignore and update IP whitelist in values files commit ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:08:14 2024 +0100 chore: Add templated directory to .gitignore and update IP whitelist in values files commit 6aeb967 Merge: f6a7c0e 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:10:27 2024 +0100 Merge pull request #71 from ministryofjustice/NIT-1305-custom-scaling-times NIT-1305 fix error in script commit 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:03:12 2024 +0100 NIT-1305 fix error in script * Update ingress-share.yaml * vals * kustomize base * ingress * setup makefiel * ingress poc patches * correct poc ingress * Update values.yaml * update for helm values mergign * updates * kustomization base * rearrange patching for ingress to repeat less * fix ingress patching with allow list * :fire: remove alf charts * rename values files * :tada: Add kustomize patching for dev environment (#84) * 🎉 Add kustomize patching for dev environment * ♻️ refactoring prefixes * ✨ Uncouple the reindexing job from the main helm charts (#83) * update values for opensearch * add makefile +chart changes * Update values.yaml * Update values.yaml * update makefile * Update values.yaml * Update values.yaml * Update values.yaml * vars * Update values.yaml * Update values.yaml * images * config map * Revert "config map" This reverts commit e714ada. * Reapply "config map" This reverts commit c47acb8. * config map * images * Squashed commit of the following: commit 6cda4f5 Merge: a682b79 ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 15:03:01 2024 +0100 Merge pull request #75 from ministryofjustice/fix-ingress-share-real Revert share ingress to dedicated hostname + enable redirect to /share commit ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 13:15:37 2024 +0100 redirect to /share commit a682b79 Merge: 066cecc 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:23:05 2024 +0100 Merge pull request #74 from ministryofjustice/remove-share-sub-domain Remove share subdomain commit 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:21:18 2024 +0100 remove share subdomain commit 066cecc Merge: 4d23e4b b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:36:49 2024 +0100 Merge pull request #73 from ministryofjustice/workflow-changes Update cloud-platform-deploy-release.yml commit b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:35:57 2024 +0100 Update cloud-platform-deploy-release.yml commit 4d23e4b Merge: 6aeb967 ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:09:57 2024 +0100 Merge pull request #72 from ministryofjustice/add-airflow-ips chore: Add templated directory to .gitignore and update IP whitelist in values files commit ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:08:14 2024 +0100 chore: Add templated directory to .gitignore and update IP whitelist in values files commit 6aeb967 Merge: f6a7c0e 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:10:27 2024 +0100 Merge pull request #71 from ministryofjustice/NIT-1305-custom-scaling-times NIT-1305 fix error in script commit 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:03:12 2024 +0100 NIT-1305 fix error in script * Update ingress-share.yaml * vals * kustomize base * ingress * setup makefiel * ingress poc patches * correct poc ingress * Update values.yaml * update for helm values mergign * updates * kustomization base * rearrange patching for ingress to repeat less * fix ingress patching with allow list * :fire: remove alf charts * rename values files * :fire: disable reindexing job from helm values * :sparkles: Uncouple the reindexing job from the main helm charts tidy * Update values.yaml * Update values.yaml * ♻️ Get rds url from secret rather than hard coding (#85) * update values for opensearch * add makefile +chart changes * Update values.yaml * Update values.yaml * update makefile * Update values.yaml * Update values.yaml * Update values.yaml * vars * Update values.yaml * Update values.yaml * images * config map * Revert "config map" This reverts commit e714ada. * Reapply "config map" This reverts commit c47acb8. * config map * images * Squashed commit of the following: commit 6cda4f5 Merge: a682b79 ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 15:03:01 2024 +0100 Merge pull request #75 from ministryofjustice/fix-ingress-share-real Revert share ingress to dedicated hostname + enable redirect to /share commit ca20a8c Author: George Taylor <[email protected]> Date: Tue Jul 16 13:15:37 2024 +0100 redirect to /share commit a682b79 Merge: 066cecc 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:23:05 2024 +0100 Merge pull request #74 from ministryofjustice/remove-share-sub-domain Remove share subdomain commit 1780e23 Author: George Taylor <[email protected]> Date: Tue Jul 16 11:21:18 2024 +0100 remove share subdomain commit 066cecc Merge: 4d23e4b b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:36:49 2024 +0100 Merge pull request #73 from ministryofjustice/workflow-changes Update cloud-platform-deploy-release.yml commit b21f656 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:35:57 2024 +0100 Update cloud-platform-deploy-release.yml commit 4d23e4b Merge: 6aeb967 ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:09:57 2024 +0100 Merge pull request #72 from ministryofjustice/add-airflow-ips chore: Add templated directory to .gitignore and update IP whitelist in values files commit ca1cfb2 Author: George Taylor <[email protected]> Date: Thu Jul 11 15:08:14 2024 +0100 chore: Add templated directory to .gitignore and update IP whitelist in values files commit 6aeb967 Merge: f6a7c0e 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:10:27 2024 +0100 Merge pull request #71 from ministryofjustice/NIT-1305-custom-scaling-times NIT-1305 fix error in script commit 540fe64 Author: Prem Basumatary <[email protected]> Date: Fri Jul 5 09:03:12 2024 +0100 NIT-1305 fix error in script * Update ingress-share.yaml * vals * kustomize base * ingress * setup makefiel * ingress poc patches * correct poc ingress * Update values.yaml * update for helm values mergign * updates * kustomization base * rearrange patching for ingress to repeat less * fix ingress patching with allow list * :fire: remove alf charts * rename values files * :fire: disable reindexing job from helm values * :sparkles: Uncouple the reindexing job from the main helm charts tidy * set helm values dynamically * Update makefile * :wrench: changes from dev deploy * :wrench: Add test environment * ✏️ incorrect ref in naming * amq --------- Co-authored-by: pete-j-g <[email protected]> Co-authored-by: Piotr Grzeskowiak <[email protected]> Co-authored-by: Prem Basumatary <[email protected]> Co-authored-by: Shahzad Chaudhry <[email protected]> Co-authored-by: Shahzad Chaudhry <[email protected]> Co-authored-by: Prem Basumatary <[email protected]> Co-authored-by: Andrew Moore <[email protected]> Co-authored-by: Andrew Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.