Skip to content

Commit

Permalink
Remove ambiguous naming
Browse files Browse the repository at this point in the history
  • Loading branch information
bill-buchan committed Jan 8, 2025
1 parent 737d881 commit b2cb17b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ansible-aws-image-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
path: /tmp/ansible-aws-image.tar
retention-days: 1

scan-observer-image:
scan-image:
name: Scan Image
needs: build-image
permissions:
Expand Down Expand Up @@ -93,12 +93,12 @@ jobs:
scan-type: 'image'
trivyignores: 'docker/delius-ansible-aws/.trivyignore'
ignore-unfixed: 'true'
output: 'trivy-results-observer.sarif'
output: 'trivy-results.sarif'
- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v3
if: failure() # If Trivy found vulnerabilities
with:
sarif_file: 'trivy-results-observer.sarif'
sarif_file: 'trivy-results.sarif'

publish-image:
name: Publish image
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/oracle-observer-image-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
name: oracle-client-zip
path: /tmp/LINUX.X64_193000_client.zip

build-image:
build-observer-image:
runs-on: ubuntu-22.04
needs: download-client-software

Expand Down Expand Up @@ -112,9 +112,9 @@ jobs:
path: /tmp/oracle-observer-image.tar
retention-days: 1

scan-image:
scan-observer-image:
name: Scan Image
needs: build-image
needs: build-observer-image
permissions:
# required for all workflows
security-events: write
Expand Down Expand Up @@ -156,9 +156,9 @@ jobs:
with:
sarif_file: 'trivy-results.sarif'

publish-image:
publish-observer-image:
name: Publish image
needs: [build-image, scan-image]
needs: [build-observer-image, scan-observer-image]
permissions:
contents: write
packages: write
Expand Down

0 comments on commit b2cb17b

Please sign in to comment.