INC-1147: Generically typed domain event #404
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushkarev
commented
Apr 4, 2023
| assertThat(domainEvent.eventType).isEqualTo(eventType) | ||
|
|
||
| return domainEvent | ||
| } | ||
|
|
||
| protected fun getPublishedDomainEvents(): List<HMPPSDomainEvent> { | ||
| protected fun getPublishedDomainEvents(): List<HMPPSDomainEvent<Map<String, *>>> { |
There was a problem hiding this comment.
Map<String, *> is an effective super set of IncentiveLevelRef and PrisonIncentiveLevelRef or any other non-null additional information structure
ushkarev
force-pushed
the
generic-domain-event
branch
from
23814db to
961e051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMPPS domain events have a nullable field (
additionalInformation) that can contain any old object, it depends on the event type. Right now, we model this field using a highly polymorphic class with nullable fields for every possible use. This prevents us from using strong typing to ensure correct fields are used in the correct places.This PR is an attempt to make the domain event generic over this field.
I'm not totally convinced by this! Generics + Jackson deserialisation do not always play well together… and tests aren't properly stable (see 2 CI runs on identical commit hash).