Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚑 Correct logic for matched user sets + role filtering #55

Merged
merged 5 commits into from
Jul 25, 2024
Merged

🚑 Correct logic for matched user sets + role filtering #55

merged 5 commits into from
Jul 25, 2024

Conversation

georgepstaylor
Copy link
Member

@georgepstaylor georgepstaylor commented Jul 24, 2024 •
edited
Loading

🚑 Correct logic for matched user sets + role filtering

@georgepstaylor georgepstaylor requested a review from a team as a code owner July 24, 2024 16:19
@georgepstaylor georgepstaylor changed the title 🚑 correct logic for matched user sets + role filtering 🚑 Correct logic for matched user sets + role filtering Jul 24, 2024
@georgepstaylor georgepstaylor merged commit 2217277 into dev Jul 25, 2024
1 check passed
@georgepstaylor georgepstaylor mentioned this pull request Jul 29, 2024
Merged
georgepstaylor added a commit that referenced this pull request Jul 29, 2024
@georgepstaylor @github-actions @dependabot
✨ Implement paging for searching users and roles in update_user_roles…
191ef62 
… job (#59)

* 🐛 Fix incorrect module path for update user roles (#51)

* 🚑  Update User Roles: Use sync search and add summary (#52)

* 🚑 Use sync search and add summary for searches and actions

* Formatted code with black --line-length 120

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Better summary for update user roles job (#53)

* 🚑 Use sync search and add summary for searches and actions

* Formatted code with black --line-length 120

* better debugging

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Update user.py

* 🚑 Correct logic for matched user sets + role filtering (#55)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix update user role cmd (#56)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

* Formatted code with black --line-length 120

* aliasing

* Update user.py

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix update user role cmd (#57)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

* Formatted code with black --line-length 120

* aliasing

* Update user.py

* Update user.py

* Formatted code with black --line-length 120

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* ✨ Use paged search to support larger data sets (#58)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

* Formatted code with black --line-length 120

* aliasing

* Update user.py

* Update user.py

* Formatted code with black --line-length 120

* implement paging because we love ldap ❤️

* remove test case + add var for page size

* Formatted code with black --line-length 120

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Bump setuptools from 71.1.0 to 72.0.0 (#60)

Bumps [setuptools](https://github.com/pypa/setuptools) from 71.1.0 to 72.0.0.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v71.1.0...v72.0.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@georgepstaylor georgepstaylor mentioned this pull request Aug 8, 2024
Closed
georgepstaylor added a commit that referenced this pull request Sep 20, 2024
@georgepstaylor @github-actions
🚑 Correct logic for matched user sets + role filtering (#55)
cb4850b 
* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
georgepstaylor added a commit that referenced this pull request Sep 20, 2024
@georgepstaylor @github-actions @dependabot
Merge dev into main (#74)
653bfa7 
* 🐛 Fix incorrect module path for update user roles (#51)

* 🚑  Update User Roles: Use sync search and add summary (#52)

* 🚑 Use sync search and add summary for searches and actions

* Formatted code with black --line-length 120

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Better summary for update user roles job (#53)

* 🚑 Use sync search and add summary for searches and actions

* Formatted code with black --line-length 120

* better debugging

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Update user.py

* 🚑 Correct logic for matched user sets + role filtering (#55)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix update user role cmd (#56)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

* Formatted code with black --line-length 120

* aliasing

* Update user.py

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix update user role cmd (#57)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

* Formatted code with black --line-length 120

* aliasing

* Update user.py

* Update user.py

* Formatted code with black --line-length 120

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* ✨ Use paged search to support larger data sets (#58)

* 🚑 correct logic for matched user sets + role filtering

* Formatted code with black --line-length 120

* Update role filter logic in user.py

* Formatted code with black --line-length 120

* aliasing

* Update user.py

* Update user.py

* Formatted code with black --line-length 120

* implement paging because we love ldap ❤️

* remove test case + add var for page size

* Formatted code with black --line-length 120

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Bump setuptools from 71.1.0 to 72.0.0 (#60)

Bumps [setuptools](https://github.com/pypa/setuptools) from 71.1.0 to 72.0.0.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v71.1.0...v72.0.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 🐛 Fix error handling for policy/role recreation (#65)

* 🐛 error handling for policy/role recreation

* 🎨 formatting

* ♻️ Add image build (#66)

* 🎨 formatting

* 🔧 Implement Ruff as required check instead of Black creating a commit re-formatting code (#73)

* 🔧 Implement Ruff as check instead of Black creating a commit

* Update python-checks.yml

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmooreio andrewmooreio andrewmooreio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgepstaylor @andrewmooreio