👷 Build images on PR and comment the tag for each run #75

georgepstaylor · 2024-09-20T13:47:18Z

No description provided.

github-actions · 2024-09-20T13:47:33Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T13:47:37Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

github-actions · 2024-09-20T13:49:48Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T13:49:48Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

github-actions · 2024-09-20T13:50:40Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

github-actions · 2024-09-20T13:50:41Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T13:54:18Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T13:54:18Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

github-actions · 2024-09-20T13:55:42Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

github-actions · 2024-09-20T13:55:44Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T13:59:41Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T13:59:41Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

github-actions · 2024-09-20T14:05:02Z

🚨 Python code is not properly formatted. Click to expand.

Would reformat: cli/ldap_cmds/user.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

github-actions · 2024-09-20T14:05:05Z

🚨 Linting errors found in Python code. Click to expand.

cli/__init__.py:143:1: SyntaxError: Expected an indented block after function definition
    |
143 | @click.command()
    | ^
144 | @click.option(
145 |     "-t",
    |

cli/ldap_cmds/rbac.py:9:5: F401 [*] `cli.ldap_cmds.ldap_connect` imported but unused
   |
 8 | from cli.ldap_cmds import (
 9 |     ldap_connect,
   |     ^^^^^^^^^^^^ F401
10 | )
11 | from cli import (
   |
   = help: Remove unused import: `cli.ldap_cmds.ldap_connect`

cli/ldap_cmds/rbac.py:143:23: F541 [*] f-string without any placeholders
    |
141 |         )
142 |     except Exception as e:
143 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
144 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:185:23: F541 [*] f-string without any placeholders
    |
183 |         )
184 |     except Exception as e:
185 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
186 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:244:23: F541 [*] f-string without any placeholders
    |
242 |         )
243 |     except Exception as e:
244 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
245 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:266:35: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
264 |         )
265 |         tree.reverse()
266 |     except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                   ^^^^^^^^^^^^^^^^ F841
267 |         log.debug("Entire policy ou does not exist, no need to delete child objects")
268 |         tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:336:23: F541 [*] f-string without any placeholders
    |
334 |         )
335 |     except Exception as e:
336 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
337 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:361:39: F841 [*] Local variable `no_such_object_e` is assigned to but never used
    |
359 |             )
360 |             tree.reverse()
361 |         except ldap.NO_SUCH_OBJECT as no_such_object_e:
    |                                       ^^^^^^^^^^^^^^^^ F841
362 |             log.debug("Entire role ou does not exist, no need to delete child objects")
363 |             tree = None
    |
    = help: Remove assignment to unused variable `no_such_object_e`

cli/ldap_cmds/rbac.py:430:23: F541 [*] f-string without any placeholders
    |
428 |         )
429 |     except Exception as e:
430 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
431 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:446:43: F821 Undefined name `dn`
    |
444 |         # loop through the records
445 |         for entry in records.all_records:
446 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
447 |             # add the record to ldap
448 |             try:
    |

cli/ldap_cmds/rbac.py:474:23: F541 [*] f-string without any placeholders
    |
472 |         )
473 |     except Exception as e:
474 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
475 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/rbac.py:478:23: F541 [*] f-string without any placeholders
    |
477 |     except Exception as e:
478 |         log.exception(f"Failed to connect to ldap")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
479 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:14:24: F401 [*] `ldap.modlist` imported but unused
   |
12 | import ldap
13 | from ldap.controls import SimplePagedResultsControl
14 | import ldap.modlist as modlist
   |                        ^^^^^^^ F401
15 | 
16 | from cli.ldap_cmds import (
   |
   = help: Remove unused import: `ldap.modlist`

cli/ldap_cmds/user.py:22:5: F401 [*] `ldap3.DEREF_ALWAYS` imported but unused
   |
20 |     MODIFY_REPLACE,
21 |     MODIFY_DELETE,
22 |     DEREF_ALWAYS,
   |     ^^^^^^^^^^^^ F401
23 | )
   |
   = help: Remove unused import: `ldap3.DEREF_ALWAYS`

cli/ldap_cmds/user.py:157:23: F541 [*] f-string without any placeholders
    |
155 |             )
156 |     except Exception as e:
157 |         log.exception(f"Failed to add role to user")
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
158 |         raise e
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:354:13: F841 Local variable `removed` is assigned to but never used
    |
352 |                 log.debug(ldap_connection_action.result)
353 |         elif remove:
354 |             removed = 0
    |             ^^^^^^^ F841
355 |             not_removed = 0
356 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:355:13: F841 Local variable `not_removed` is assigned to but never used
    |
353 |         elif remove:
354 |             removed = 0
355 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
356 |             failed = 0
357 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:437:13: E722 Do not use bare `except`
    |
435 |                 connection.commit()
436 |                 log.info("Committed changes to database successfully")
437 |             except:
    |             ^^^^^^ E722
438 |                 log.exception(f"Failed to update notes for user {user}")
439 |         connection.close()
    |

cli/ldap_cmds/user.py:528:26: F541 [*] f-string without any placeholders
    |
526 |     for user_dn in all_users:
527 |         try:
528 |             update_sql = f"UPDATE USER_ SET END_DATE=TRUNC(CURRENT_DATE) WHERE UPPER(DISTINGUISHED_NAME)=UPPER(:user_dn)"
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ F541
529 |             update_cursor = connection.cursor()
530 |             update_cursor.execute(
    |
    = help: Remove extraneous `f` prefix

cli/ldap_cmds/user.py:538:9: E722 Do not use bare `except`
    |
536 |             connection.commit()
537 |             log.info("Committed changes to database successfully")
538 |         except:
    |         ^^^^^^ E722
539 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
540 |     connection.close()
    |

Found 20 errors.
[*] 14 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

👷 Build images on PR and comment the tag for each run

b39dddb

georgepstaylor requested a review from a team as a code owner September 20, 2024 13:47

Update image-build.yml

7cf703a

georgepstaylor force-pushed the building-image-on-pr branch from 06b45b8 to 7cf703a Compare September 20, 2024 13:50

georgepstaylor force-pushed the building-image-on-pr branch from 700b365 to 4aa8923 Compare September 20, 2024 13:55

Update image-build.yml

26ecb3c

georgepstaylor force-pushed the building-image-on-pr branch from 4aa8923 to 26ecb3c Compare September 20, 2024 13:59

Update image-build.yml

5cc7c5a

georgepstaylor merged commit 2e3e885 into main Nov 11, 2024
2 of 5 checks passed

georgepstaylor mentioned this pull request Nov 11, 2024

Revert ":construction_worker: Build images on PR and comment the tag for each run" #81

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

👷 Build images on PR and comment the tag for each run #75

👷 Build images on PR and comment the tag for each run #75

georgepstaylor commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

👷 Build images on PR and comment the tag for each run #75

👷 Build images on PR and comment the tag for each run #75

Conversation

georgepstaylor commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024