Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump click from 8.1.7 to 8.1.8 #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 23, 2024

Bumps click from 8.1.7 to 8.1.8.

Release notes

Sourced from click's releases.

8.1.8

This is the Click 8.1.8 fix release, which fixes bugs but does not otherwise change behavior and should not result in breaking changes compared to the latest feature release.

PyPI: https://pypi.org/project/click/8.1.8/ Changes: https://click.palletsprojects.com/en/stable/changes/#version-8-1-8 Milestone https://github.com/pallets/click/milestones/23?closed=1

  • Fix an issue with type hints for click.open_file(). #2717
  • Fix issue where error message for invalid click.Path displays on multiple lines. #2697
  • Fixed issue that prevented a default value of "" from being displayed in the help for an option. #2500
  • The test runner handles stripping color consistently on Windows. #2705
  • Show correct value for flag default when using default_map. #2632
  • Fix click.echo(color=...) passing color to coloroma so it can be forced on Windows. #2606.
  • More robust bash version check, fixing problem on Windows with git-bash. #2638
  • Cache the help option generated by the help_option_names setting to respect its eagerness. #2811
  • Replace uses of os.system with subprocess.Popen. #1476
  • Exceptions generated during a command will use the context's color setting when being displayed. #2193
  • Error message when defining option with invalid name is more descriptive. #2452
  • Refactor code generating default --help option to deduplicate code. #2563
  • Test CLIRunner resets patched _compat.should_strip_ansi. #2732
Changelog

Sourced from click's changelog.

Version 8.1.8

Unreleased

  • Fix an issue with type hints for click.open_file(). :issue:2717
  • Fix issue where error message for invalid click.Path displays on multiple lines. :issue:2697
  • Fixed issue that prevented a default value of "" from being displayed in the help for an option. :issue:2500
  • The test runner handles stripping color consistently on Windows. :issue:2705
  • Show correct value for flag default when using default_map. :issue:2632
  • Fix click.echo(color=...) passing color to coloroma so it can be forced on Windows. :issue:2606.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [click](https://github.com/pallets/click) from 8.1.7 to 8.1.8.
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.7...8.1.8)

---
updated-dependencies:
- dependency-name: click
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner December 23, 2024 08:58
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 23, 2024
Copy link
Contributor

🚨 Linting errors found in Python code. Click to expand.
cli/ldap_cmds/rbac.py:466:43: F821 Undefined name `dn`
    |
464 |         # loop through the records
465 |         for entry in records.all_records:
466 |             log.info(f"Got entry record: {dn}")
    |                                           ^^ F821
467 |             # add the record to ldap
468 |             try:
    |

cli/ldap_cmds/user.py:349:13: F841 Local variable `removed` is assigned to but never used
    |
347 |                 log.debug(ldap_connection_action.result)
348 |         elif remove:
349 |             removed = 0
    |             ^^^^^^^ F841
350 |             not_removed = 0
351 |             failed = 0
    |
    = help: Remove assignment to unused variable `removed`

cli/ldap_cmds/user.py:350:13: F841 Local variable `not_removed` is assigned to but never used
    |
348 |         elif remove:
349 |             removed = 0
350 |             not_removed = 0
    |             ^^^^^^^^^^^ F841
351 |             failed = 0
352 |             ldap_connection_action.delete(
    |
    = help: Remove assignment to unused variable `not_removed`

cli/ldap_cmds/user.py:432:13: E722 Do not use bare `except`
    |
430 |                 connection.commit()
431 |                 log.info("Committed changes to database successfully")
432 |             except:
    |             ^^^^^^ E722
433 |                 log.exception(f"Failed to update notes for user {user}")
434 |         connection.close()
    |

cli/ldap_cmds/user.py:533:9: E722 Do not use bare `except`
    |
531 |             connection.commit()
532 |             log.info("Committed changes to database successfully")
533 |         except:
    |         ^^^^^^ E722
534 |             log.exception(f"Failed to update END_DATE for user {user_dn}")
535 |     connection.close()
    |

Found 5 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

Tip: You can run ruff check --fix to fix automatically fixable errors.

Copy link
Contributor

🚨 Python code is not properly formatted. Click to expand.
Would reformat: cli/ldap_cmds/rbac.py
1 file would be reformatted, 8 files already formatted

Please run ruff format to format the code.

Copy link
Contributor

Image built and pushed to ghcr.io/ministryofjustice/hmpps-ldap-automation:dependabot-pip-main-click-8.1.8-12464107420-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants