Skip to content

Commit

Permalink
NON-318: Test node REST client library on node.js 22 (#373)
Browse files Browse the repository at this point in the history
  • Loading branch information
dependabot[bot] authored Oct 25, 2024
1 parent 72a81fe commit 012c3ea
Show file tree
Hide file tree
Showing 6 changed files with 66 additions and 64 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ workflows:
- test-node-client:
matrix:
parameters:
node-version: ["18.20", "20.16"]
node-version: ["18.20", "20.18", "22.10"]
- hmpps/helm_lint:
name: helm_lint
- hmpps/build_multiplatform_docker:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-node-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Setup node with private registry
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
cache: npm
cache-dependency-path: clients/node/package-lock.json
registry-url: 'https://npm.pkg.github.com'
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Setup node with public registry
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
cache: npm
cache-dependency-path: clients/node/package-lock.json
registry-url: 'https://registry.npmjs.org'
Expand Down
2 changes: 1 addition & 1 deletion clients/node/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
22
113 changes: 57 additions & 56 deletions clients/node/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions clients/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
"test": "jest"
},
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"dependencies": {
"agentkeepalive": ">=4",
"superagent": ">=9"
},
"devDependencies": {
"@tsconfig/node20": "^20.1.4",
"@tsconfig/node22": "^22.0.0",
"@types/jest": "^29.5.12",
"@types/node": "^20.16.1",
"@types/node": "^22.8.0",
"@types/superagent": "^8.1.9",
"@types/supertest": "^6.0.2",
"@typescript-eslint/eslint-plugin": "^8.0.1",
Expand Down
3 changes: 2 additions & 1 deletion clients/node/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"extends": "@tsconfig/node20/tsconfig.json",
"$schema": "https://json.schemastore.org/tsconfig",
"extends": "@tsconfig/node22/tsconfig.json",
"compileOnSave": true,
"compilerOptions": {
"outDir": "./dist",
Expand Down

0 comments on commit 012c3ea

Please sign in to comment.