Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPS-1054: Renamed template project to hmpps-person-integration-api #2

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

mtac50
Copy link
Contributor

@mtac50 mtac50 commented Nov 18, 2024

No description provided.

brightonsbox
brightonsbox previously approved these changes Nov 18, 2024
Copy link
Contributor

@brightonsbox brightonsbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -17,4 +17,4 @@ generic-service:
# CloudPlatform AlertManager receiver to route prometheus alerts to slack
# See https://user-guide.cloud-platform.service.justice.gov.uk/documentation/monitoring-an-app/how-to-create-alarms.html#creating-your-own-custom-alerts
generic-prometheus-alerts:
alertSeverity: NON_PROD_ALERTS_SEVERITY_LABEL
alertSeverity: digital-prison-service-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually check line 8 above - ingress still template-kotlin-dev.hmpps.service.justice.gov.uk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks!

Copy link
Contributor

@brightonsbox brightonsbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtac50 mtac50 merged commit 3a77b7d into main Nov 18, 2024
4 checks passed
@mtac50 mtac50 deleted the rename-project branch November 18, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants