CDPS-1054: Added template API for iteration 1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtac50
commented
Nov 19, 2024
mtac50
commented
- Final references to the template project updated.
- Template API for iteration 1 added.
- Basic tests added.
- Dev deployment fixed.
- Security check notification pointed at conect-dps-dev
…otected Characteristics domains.
mtac50
commented
Nov 19, 2024
mtac50
commented
Nov 19, 2024
…to the local hmpps auth container url
…to reference data to either role.
...ersonintegrationapi/common/config/UserEnhancedOAuth2ClientCredentialGrantRequestConverter.kt
Outdated
Show resolved
Hide resolved
...in/uk/gov/justice/digital/hmpps/personintegrationapi/common/config/WebClientConfiguration.kt
Outdated
Show resolved
Hide resolved
...mpps/personintegrationapi/corepersonrecord/dto/request/CorePersonRecordV1UpdateRequestDto.kt
Outdated
Show resolved
Hide resolved
| required = true, | ||
| nullable = false, | ||
| ) | ||
| val fieldValue: String, |
There was a problem hiding this comment.
Are we only able to update strings using this request?
There was a problem hiding this comment.
I suppose birth date will follow at some point as an example
There was a problem hiding this comment.
This was mainly just for the iteration 1 fields as the PoC. This will be expanded to a more complete object using either JSONNullable or the Nullish type from the prison person api.
...e/digital/hmpps/personintegrationapi/corepersonrecord/resource/CorePersonRecordV1Resource.kt
Show resolved
Hide resolved
...e/digital/hmpps/personintegrationapi/corepersonrecord/resource/CorePersonRecordV1Resource.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.