PI-2660 Fix stored procedure call (#4458)

* PI-2660 bugfix * PI-2660 bugfix
ministryofjustice · Nov 22, 2024 · 2aff051 · 2aff051
1 parent d7b92e5
commit 2aff051
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 31 deletions.
diff --git a/projects/common-platform-and-delius/src/dev/resources/db/h2.sql b/projects/common-platform-and-delius/src/dev/resources/db/h2.sql
diff --git a/projects/common-platform-and-delius/src/dev/resources/db/oracle.sql b/projects/common-platform-and-delius/src/dev/resources/db/oracle.sql
diff --git a/...-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/integrations/delius/entity/Person.kt b/...-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/integrations/delius/entity/Person.kt
@@ -104,4 +104,7 @@ class Person(
 interface PersonRepository : JpaRepository<Person, Long> {
     @Query("SELECT SOUNDEX(:name) FROM DUAL", nativeQuery = true)
     fun getSoundex(name: String): String
+
+    @Query(value = "SELECT offender_support_api.getNextCRN FROM DUAL", nativeQuery = true)
+    fun getNextCrn(): String
 }
diff --git a/...platform-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/PersonService.kt b/...platform-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/PersonService.kt
@@ -1,7 +1,5 @@
 package uk.gov.justice.digital.hmpps.service
 
-import org.springframework.jdbc.core.JdbcTemplate
-import org.springframework.jdbc.core.simple.SimpleJdbcCall
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
 import uk.gov.justice.digital.hmpps.audit.service.AuditableService
@@ -18,7 +16,6 @@ import java.time.Period
 
 @Service
 class PersonService(
-    jdbcTemplate: JdbcTemplate,
     auditedInteractionService: AuditedInteractionService,
     private val personRepository: PersonRepository,
     private val courtRepository: CourtRepository,
@@ -30,10 +27,6 @@ class PersonService(
     private val personAddressRepository: PersonAddressRepository
 ) : AuditableService(auditedInteractionService) {
 
-    private val generateCrn = SimpleJdbcCall(jdbcTemplate)
-        .withCatalogName("offender_support_api")
-        .withFunctionName("getNextCRN")
-
     @Transactional
     fun insertPerson(defendant: Defendant, courtCode: String): InsertPersonResult =
         audit(BusinessInteractionCode.INSERT_PERSON) { audit ->
@@ -108,7 +101,7 @@ class PersonService(
     }
 
     fun generateCrn(): String {
-        return generateCrn.executeFunction(String::class.java)
+        return personRepository.getNextCrn()
     }
 
     fun String.toDeliusGender() = ReferenceData.GenderCode.entries.find { it.commonPlatformValue == this }?.deliusValue

diff --git a/projects/common-platform-and-delius/src/main/resources/application.yml b/projects/common-platform-and-delius/src/main/resources/application.yml
@@ -46,8 +46,6 @@ server.shutdown: immediate
 
 spring:
   datasource.url: jdbc:h2:file:./dev;MODE=Oracle;DEFAULT_NULL_ORDERING=HIGH;AUTO_SERVER=true;AUTO_SERVER_PORT=9092
-  sql.init.mode: always
-  sql.init.data-locations: classpath:db/h2.sql
   jpa:
     hibernate.ddl-auto: create-drop