PI-1630 updates for OPD Assessment processing

ministryofjustice · Nov 7, 2023 · 843a1ea · 843a1ea
1 parent 1537737
commit 843a1ea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/projects/opd-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/NsiService.kt b/projects/opd-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/NsiService.kt
@@ -33,19 +33,19 @@ class NsiService(
         val type = nsiTypeRepository.getByCode(NsiType.Code.OPD_COMMUNITY_PATHWAY.value)
         val subType = opdAssessment.result.subTypeCode?.value?.let { nsiSubTypeRepository.nsiSubType(it) }
         val status = nsiStatusRepository.getByCode(NsiStatus.Code.READY_FOR_SERVICE.value)
-        val nsi = nsiRepository.save(
-            Nsi(
-                com.person,
-                opdAssessment.date.toLocalDate(),
-                type,
-                subType,
-                status,
-                opdAssessment.date,
-                opdAssessment.date,
-                com.providerId
-            )
+        val nsi = Nsi(
+            com.person,
+            opdAssessment.date.toLocalDate(),
+            type,
+            subType,
+            status,
+            opdAssessment.date,
+            opdAssessment.date,
+            com.providerId
         )
         nsi.appendNotes(opdAssessment.notes)
+        nsiRepository.save(nsi)
+
         nsiManagerRepository.save(
             NsiManager(
                 nsi,

diff --git a/projects/opd-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/OpdService.kt b/projects/opd-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/OpdService.kt
@@ -20,7 +20,7 @@ class OpdService(
         val nsi = nsiService.findOpdNsi(com.person.id)
 
         when {
-            activeEvent && nsi == null -> {
+            activeEvent && nsi?.active != true -> {
                 nsiService.createNsi(opdAssessment, com)
             }