MAN-28 - do not include lc notes if there are not any

ministryofjustice · Oct 17, 2024 · ad2edf2 · ad2edf2
1 parent f8f24a9
commit ad2edf2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...elius/src/main/kotlin/uk/gov/justice/digital/hmpps/api/model/sentence/LicenceCondition.kt b/...elius/src/main/kotlin/uk/gov/justice/digital/hmpps/api/model/sentence/LicenceCondition.kt
@@ -7,7 +7,7 @@ data class LicenceCondition(
     val subTypeDescription: String? = null,
     val imposedReleasedDate: LocalDate,
     val actualStartDate: LocalDate? = null,
-    val notes: List<LicenceConditionNote> = listOf()
+    val notes: List<LicenceConditionNote>? = null
 )
 
 data class LicenceConditionNote(

diff --git a/...vision-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/SentenceService.kt b/...vision-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/SentenceService.kt
@@ -87,7 +87,7 @@ class SentenceService(
             populateLicenceConditionNotes(notes)
         )
 
-    fun populateLicenceConditionNotes(notes: String?): List<LicenceConditionNote> {
+    fun populateLicenceConditionNotes(notes: String?): List<LicenceConditionNote>? {
         val noteLength = 1500
 
         notes?.let {
@@ -115,7 +115,8 @@ class SentenceService(
             }
 
         }
-        return listOf()
+
+        return null
     }
 
     fun ExtraSentence.toAdditionalSentence(): AdditionalSentence =