PI-1558 Update PSR extension to PDF when complete #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an empty PDF would be uploaded to the Alfresco when the initial draft was started. Following the recent changes, Delius now uploads a .doc file instead as the draft. However, the filename remains the same after the report is completed. So currently we end up with a PDF document saved as e.g. ``` Nat Short format pre-sentence report_13102023_112036_Larson_D_X729742.doc ``` This PR updates the extension to .pdf before saving
anthony-britton-moj
approved these changes
Oct 13, 2023
marcus-bcl
added a commit
that referenced
this pull request
Oct 16, 2023
This is an extension of #2384
marcus-bcl
added a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an empty PDF would be uploaded to the Alfresco when the initial draft was started. Following the recent changes, Delius now uploads a .doc file instead as the draft. However, the filename remains the same after the report is completed.
So we end up with a PDF document saved as e.g.
This PR updates the extension to .pdf before saving