Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS-1178 - setup documents data for cas1 team #4367

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

gregkhawkins
Copy link
Contributor

Background

  • We are migrating away from Community API's GET secure/offenders/crn/{crn}/documents/grouped endpoint
  • Instead we plan to integrate with the AP and Delius API's GET /documents/{crn}/all endpoint
  • For everything to work locally in our AP tools (i.e. local docker infrastructure) we need some extra documents to be setup in the AP and Delius API's local H2 database

PR includes

  • Data setup for new docs
  • New wiremock mapping file to surface docs in the way we require

@gregkhawkins gregkhawkins requested a review from a team as a code owner October 30, 2024 17:38
@gregkhawkins gregkhawkins force-pushed the CAS-1178__setup_documents_data_for_cas1_team branch from 3fbddbe to d6f2464 Compare October 30, 2024 18:03
marcus-bcl
marcus-bcl previously approved these changes Oct 31, 2024
@marcus-bcl
Copy link
Contributor

@gregkhawkins we enforce signed commits in this repo. Happy to help you set that up - you just need to generate a GPG key, register it with your GitHub account, and use it to sign your commits. See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@gregkhawkins gregkhawkins force-pushed the CAS-1178__setup_documents_data_for_cas1_team branch from d6f2464 to 8cfec61 Compare October 31, 2024 10:05
@gregkhawkins gregkhawkins dismissed marcus-bcl’s stale review October 31, 2024 11:03

The merge-base changed after approval.

@gregkhawkins gregkhawkins force-pushed the CAS-1178__setup_documents_data_for_cas1_team branch from a97ce3c to b62823b Compare October 31, 2024 11:03
@gregkhawkins gregkhawkins merged commit 9c4bad5 into main Oct 31, 2024
57 checks passed
@gregkhawkins gregkhawkins deleted the CAS-1178__setup_documents_data_for_cas1_team branch October 31, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants