Man 108 record if complied and update note #4442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcus-bcl
reviewed
Nov 19, 2024
Comment on lines
+31
to
+33
| Comment added by ${outcome.recordedBy} on ${ | ||
| dateTime.format(DeliusDateTimeFormatter).substring(0, 10) | ||
| } at ${dateTime.format(DeliusDateTimeFormatter).substring(11, 16)} |
There was a problem hiding this comment.
Isn't this line added by the Delius DB trigger? Do you need to add it manually?
There was a problem hiding this comment.
When I ran the api in dev, only the note was added. The 'created by' part was empty, see second contact for D001024 in dev.
There was a problem hiding this comment.
I think that's because you're overwriting the notes rather than appending to them?
There was a problem hiding this comment.
I believe so, you might need to stick a new line in there as well but I'm not sure.
There was a problem hiding this comment.
going to deploy my branch to dev with an update to see if the notes are created successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.