Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alee/heat 353 typescript node workflow lint errors #450

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Pipeline

on:
push:
branches:
# - main
- '**'
workflow_dispatch:
inputs:
environment:
description: Environment
type: choice
required: true
options:
- dev
- prod
- staging
default: 'dev'
version: # Only used when run manually - build.yml will include it
description: Image version
type: string
required: true

jobs:
# main node build workflow
node_build:
name: node build
uses: ministryofjustice/hmpps-github-actions/.github/workflows/node_build.yml@HEAT-353-typescript-node-workflow
secrets: inherit
# generic node unit tests - feel free to override with local tests if required
node_unit_tests:
name: node unit tests
uses: ministryofjustice/hmpps-github-actions/.github/workflows/node_unit_tests.yml@HEAT-353-typescript-node-workflow
needs: [node_build]
secrets: inherit
# generic node integration tests using wiremock - feel free to override with local tests if required
node_integration_tests:
name: node integration tests
uses: ministryofjustice/hmpps-github-actions/.github/workflows/node_integration_tests.yml@HEAT-353-typescript-node-workflow
needs: [node_build]
secrets: inherit
helm_lint:
name: helm lint
uses: ministryofjustice/hmpps-github-actions/.github/workflows/test_helm_lint.yml@main
secrets: inherit
with:
environment: ${{ inputs.environment || 'dev' }}

# These bits to be done...
# build:
# name: Build
# uses: ./.github/workflows/build.yml
# with:
# push: true
# secrets: inherit

# deploy_to_dev:
# name: Deploy to dev
# uses: ./.github/workflows/deploy.yml
# needs: build
# with:
# environment: development
# version: ${{ needs.build.outputs.version }}
# secrets: inherit

# deploy_to_prod:
# name: Deploy to prod
# uses: ./.github/workflows/deploy.yml
# needs:
# - build
# - deploy_to_dev # wait for the deploy_to_dev job to complete
# with:
# environment: production
# version: ${{ needs.build.outputs.version }}
# secrets: inherit
2 changes: 1 addition & 1 deletion server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import app from './server/index'
import logger from './logger'

;

Check failure on line 6 in server.ts

View workflow job for this annotation

GitHub Actions / node build / Run the node build

Delete `;⏎`

Check failure on line 6 in server.ts

View workflow job for this annotation

GitHub Actions / node build / Run the node build

Expected 1 empty line after import statement not followed by another import
app.listen(app.get('port'), () => {
logger.info(`Server listening on port ${app.get('port')}`)
})
Loading