added tests

ministryofjustice · Dec 29, 2023 · 2fe84e0 · 2fe84e0
1 parent 74cc476
commit 2fe84e0
Showing 1 changed file with 52 additions and 9 deletions.
diff --git a/test/test_main.py b/test/test_main.py
@@ -10,12 +10,18 @@ class TestCsvToJson(unittest.TestCase):
     def setUp(self):
         # Create a temporary CSV file for testing
         self.csv_data = [
-            {'Site Name': 'Test location 1', 'Site Address': '40 Mayflower Dr, Plymouth PL2 3DG', 'Enable GovWifi': ' "TRUE"',
-                'Enable MoJWifi': ' "FALSE"', 'GovWifi Radius Key': '00000DD0000BC0EEE000', 'Wired NACS Radius Key': '00000DD0000BC0EEE000'},
-            {'Site Name': 'Test location 2', 'Site Address': '102 Petty France, London SW1H 9AJ', 'Enable GovWifi': ' "TRUE"',
-                'Enable MoJWifi': ' "FALSE"', 'GovWifi Radius Key': '0D0E0DDE000BC0EEE000', 'Wired NACS Radius Key': '00000DD0000BC0EEE000'},
-            {'Site Name': 'Test location 3', 'Site Address': 'Met Office, FitzRoy Road, Exeter, Devon, EX1 3PB', 'Enable GovWifi': ' "TRUE"',
-                'Enable MoJWifi': ' "FALSE"', 'GovWifi Radius Key': '0D0E0DDE080BC0EEE000', 'Wired NACS Radius Key': '00000DD0000BC0EEE000'}
+            {'Site Name': 'Test location 1', 'Site Address': '40 Mayflower Dr, Plymouth PL2 3DG',
+             'Enable GovWifi': ' "TRUE"',
+             'Enable MoJWifi': ' "FALSE"', 'GovWifi Radius Key': '00000DD0000BC0EEE000',
+             'Wired NACS Radius Key': '00000DD0000BC0EEE000'},
+            {'Site Name': 'Test location 2', 'Site Address': '102 Petty France, London SW1H 9AJ',
+             'Enable GovWifi': ' "TRUE"',
+             'Enable MoJWifi': ' "FALSE"', 'GovWifi Radius Key': '0D0E0DDE000BC0EEE000',
+             'Wired NACS Radius Key': '00000DD0000BC0EEE000'},
+            {'Site Name': 'Test location 3', 'Site Address': 'Met Office, FitzRoy Road, Exeter, Devon, EX1 3PB',
+             'Enable GovWifi': ' "TRUE"',
+             'Enable MoJWifi': ' "FALSE"', 'GovWifi Radius Key': '0D0E0DDE080BC0EEE000',
+             'Wired NACS Radius Key': '00000DD0000BC0EEE000'}
         ]
         self.csv_file = tempfile.NamedTemporaryFile(
             mode='w', delete=False, newline='', suffix='.csv')
@@ -51,6 +57,41 @@ def test_given_file_path_when_csv_file_not_found_then_raise_FileNotFoundError(se
         with self.assertRaises(FileNotFoundError):
             convert_csv_to_json(nonexistent_file_path)
 
+    def test_given_csv_while_when_csv_file_contains_nbsp_then_convert_to_normal_spacing(self):
+        csv_data = [
+            {'Site\xa0Name': 'Test location 1', 'Site Address': '40\xa0Mayflower\xa0Dr, Plymouth PL2 3DG',
+             'Enable GovWifi': ' "TRUE"',
+             'Enable\xa0MoJWifi': ' "FALSE"', 'GovWifi\xa0Radius Key': '00000DD0000BC0EEE000',
+             'Wired\xa0NACS Radius Key': '00000DD0000BC0EEE000'},
+            {'Site\xa0Name': 'Test location 2', 'Site Address': '102\xa0Petty\xa0France, London SW1H 9AJ',
+             'Enable GovWifi': ' "TRUE"',
+             'Enable\xa0MoJWifi': ' "FALSE"', 'GovWifi\xa0Radius Key': '0D0E0DDE000BC0EEE000',
+             'Wired\xa0NACS Radius Key': '00000DD0000BC0EEE000'},
+            {'Site\xa0Name': 'Test location 3', 'Site Address': 'Met\xa0Office, FitzRoy Road,\xa0Exeter, Devon, EX1 3PB',
+             'Enable GovWifi': ' "TRUE"',
+             'Enable\xa0MoJWifi': ' "FALSE"', 'GovWifi\xa0Radius Key': '0D0E0DDE080BC0EEE000',
+             'Wired\xa0NACS Radius Key': '00000DD0000BC0EEE000'}
+        ]
+        csv_file = tempfile.NamedTemporaryFile(
+            mode='w', delete=False, newline='', suffix='.csv')
+        csv_writer = csv.DictWriter(csv_file, fieldnames=[
+            'Site\xa0Name',
+            'Site Address',
+            'Enable GovWifi',
+            'Enable\xa0MoJWifi',
+            'GovWifi\xa0Radius Key',
+            'Wired\xa0NACS Radius Key'
+        ])
+        csv_writer.writeheader()
+        csv_writer.writerows(csv_data)
+        csv_file.close()
+
+        expected_json = self.csv_data
+        actual_json = convert_csv_to_json(csv_file.name)
+        self.assertEqual(actual_json, expected_json)
+
+
+
 
 class TestAddGeocodingToJson(unittest.TestCase):
 
@@ -72,16 +113,18 @@ def test_given_site_name_and_site_address_in_json_format_when_function_called_th
             {'Site Name': 'Site1', 'Site Address': '40 Mayflower Dr, Plymouth PL2 3DG'},
             {'Site Name': 'Site2', 'Site Address': '102 Petty France, London SW1H 9AJ'},
             {'Site Name': 'Site3',
-                'Site Address': 'Met Office, FitzRoy Road, Exeter, Devon, EX1 3PB'}
+             'Site Address': 'Met Office, FitzRoy Road, Exeter, Devon, EX1 3PB'}
         ]
 
         expected_data = [
             {'Site Name': 'Site1', 'Site Address': '40 Mayflower Dr, Plymouth PL2 3DG', 'gps': {
                 'latitude': 50.3868633, 'longitude': -4.1539256}, 'country_code': 'GB', 'time_zone': 'Europe/London'},
             {'Site Name': 'Site2', 'Site Address': '102 Petty France, London SW1H 9AJ', 'gps': {
-                'latitude': 51.499929300000005, 'longitude': -0.13477761285315926}, 'country_code': 'GB', 'time_zone': 'Europe/London'},
+                'latitude': 51.499929300000005, 'longitude': -0.13477761285315926}, 'country_code': 'GB',
+             'time_zone': 'Europe/London'},
             {'Site Name': 'Site3', 'Site Address': 'Met Office, FitzRoy Road, Exeter, Devon, EX1 3PB', 'gps': {
-                'latitude': 50.727350349999995, 'longitude': -3.4744726127760086}, 'country_code': 'GB', 'time_zone': 'Europe/London'}
+                'latitude': 50.727350349999995, 'longitude': -3.4744726127760086}, 'country_code': 'GB',
+             'time_zone': 'Europe/London'}
         ]
 
         actual_data = add_geocoding_to_json(data)