Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken out juniperscript into more readable modules #2

Merged
merged 2 commits into from
Dec 1, 2023
Merged

broken out juniperscript into more readable modules #2

merged 2 commits into from
Dec 1, 2023

Conversation

jamesgreen-moj
Copy link
Contributor

@jamesgreen-moj jamesgreen-moj commented Dec 1, 2023 •
edited
Loading

  • Init Juniper script
  • Broken out into modules
  • Only update if site does not already exist on mist (prevents overwriting)
  • Get all needed values from Excel spreadsheet "Site Name,Site Address,Enable GovWifi,Enable MoJWifi, GovWifi Radius Key, Weird NACS Radius Key"

Improvements to make:

  • Unit testing
  • Dockerisation

smjmoj
smjmoj approved these changes Dec 1, 2023
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesgreen-moj jamesgreen-moj merged commit 2230f6f into main Dec 1, 2023
@smjmoj smjmoj deleted the init-juniper branch December 7, 2023 09:07
jamesgreen-moj added a commit that referenced this pull request Dec 12, 2023
@jamesgreen-moj
Merge pull request #2 from ministryofjustice/james-branch
ecc9bdb 
James branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smjmoj smjmoj smjmoj approved these changes

@darey-io darey-io Awaiting requested review from darey-io darey-io is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgreen-moj @smjmoj