Nd 229 #25

jamesgreen-moj · 2024-03-21T00:49:39Z

Added new requirements:

On the site settings (on Rogue AP section), there’s GovWifi whitelisted. On prisons we shouldn’t have any GovWifi related config and therefore: "whitelisted_ssids": [ "GovWifi" ] section should be empty. I think you had a good idea how to implement this: if the site.csv file doesn’t have GovWifi shared secret column, this would keep whitelisted_ssids empty.
Site variable “site_specific_radius_wired_nacs_secret” is not actually required. This was for switches and the prisons are using Cisco switches, they wouldn’t get this configuration from Juniper Mist dashboard. I guess this could be done by removing the column from site.csv file similar than GovWifi secret.

Refactor:

Made unit tests better
Renamed Admin to JuniperClient to be more reflective of operation and moved into its own module
Created a new module named BuildPayload that takes responsibility for building the json output

…ific_radius_wired_nacs_secret now optional

Parameterized expanse testing

…ion_id warnings

Moved all of the build payload object into its own class, to save repetition and duplicate code

Amended build juniper payload function to return dictionare of site and site_settings

…its own class

…flective to the new scope of the juniper.py functions

smjmoj

LGTM
Great code review session.

jamesgreen-moj and others added 15 commits March 14, 2024 16:34

Updated mist script to have new production id, and govwfi & site_spec…

7bf0ba4

…ific_radius_wired_nacs_secret now optional

wip unit tests

2264008

test_juniper

9738ce8

Parameterized expanse testing

removed whitespace

37dc452

Updated tests to use parameterized org_ids, to test different product…

882d870

…ion_id warnings

Refectored the code base for maintainabilty

1fe1390

Moved all of the build payload object into its own class, to save repetition and duplicate code

Amended build juniper payload

13cba1a

Amended build juniper payload function to return dictionare of site and site_settings

Renamed Juniper Admin into Juniper client and abstracted it out into …

183fb26

…its own class

Moved unit tests over from orginal juniper to client module:

057d45b

Updating typting

d265b67

WIP unit tests

02f79de

added error handling and more tests for build payload

b61251e

moved juniper_payload tests into module

22d78dd

removed not needed todo

3a4e409

removed not needed unit test and adjusted one unit test to be more re…

a8647fe

…flective to the new scope of the juniper.py functions

jamesgreen-moj requested a review from a team as a code owner March 21, 2024 00:49

jamesgreen-moj requested review from moontune, mTouhid and asifamirat00 March 21, 2024 00:49

github-actions bot and others added 3 commits March 21, 2024 00:50

Commit changes made by code formatters

21c69dc

removed not needed commented tests

e9e44d2

corrected spelling error

edcc102

smjmoj approved these changes Mar 22, 2024

View reviewed changes

jamesgreen-moj merged commit 5684ad1 into main Mar 22, 2024
2 checks passed

jamesgreen-moj deleted the nd-229 branch March 22, 2024 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nd 229 #25

Nd 229 #25

jamesgreen-moj commented Mar 21, 2024

smjmoj left a comment

Nd 229 #25

Nd 229 #25

Conversation

jamesgreen-moj commented Mar 21, 2024

smjmoj left a comment

Choose a reason for hiding this comment