Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix csv formating #29

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Fix csv formating #29

merged 5 commits into from
Jun 10, 2024

Conversation

jamesgreen-moj
Copy link
Contributor

  • Moved csv functions into its own module named csv_utils
  • fixed for loop API issue with AP staging
  • Force all uploaded CSV's to be opened in utf-8
  • Added unit tests to ensure we can open CSV files of format iso_8859_1 and open in utf-8

@jamesgreen-moj jamesgreen-moj requested a review from a team as a code owner June 10, 2024 12:05
smjmoj
smjmoj approved these changes Jun 10, 2024
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesgreen-moj jamesgreen-moj merged commit 3498037 into main Jun 10, 2024
@jamesgreen-moj jamesgreen-moj deleted the fix-csv-formating branch June 10, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smjmoj smjmoj smjmoj approved these changes

@dms1981 dms1981 Awaiting requested review from dms1981 dms1981 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@mTouhid mTouhid Awaiting requested review from mTouhid mTouhid is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@kyphutruong kyphutruong Awaiting requested review from kyphutruong kyphutruong is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgreen-moj @smjmoj