Scope creep #7
Merged
Scope creep #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamesgreen-moj
commented
Dec 12, 2023
jamesgreen-moj
commented
- Added support for username and password login
- Added support to define custom parameters via docker file
- Added scope creep requirements
- Updated & added unit tests
When a user logins via username, password and MFA, I have now added error handling to make sure the post request login comes back with a 200 status code before continuing with the script"
Added error handing, when a user provides an API key and the API returns a non 200 error code, it will raise error to the user
MIST has many different orgs, within the orgs are site_groups_ids different for each org. This allows the user running the script to specify the org_ids for their environment.
RF_TEMPLATE_ID will be different per org thus this needs to be defined but the user running the script depending on what environment they are using
jamesgreen-moj
requested review from
ASTRobinson,
moontune,
juddin927,
a team,
mTouhid,
kyphutruong and
tommoj
and removed request for
a team,
ASTRobinson,
moontune,
juddin927,
mTouhid,
kyphutruong and
tommoj
jamesgreen-moj
force-pushed
the
scope-creep
branch
from
ca9f25c to
01c0f78
Compare
jamesgreen-moj
force-pushed
the
scope-creep
branch
from
01c0f78 to
37bbe37
Compare
trying to make it really easy for the users of the tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.