Skip to content

Commit

Permalink
remove session_reset as it does not solve the issue we were expecting…
Browse files Browse the repository at this point in the history
… it to (#1570)
  • Loading branch information
willc-work authored Oct 4, 2024
1 parent 4ae9b30 commit 4671314
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions app/controllers/providers/omniauth_callbacks_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@ def saml
provider = Provider.create! email: info_hash_email, first_office_code: info_hash_office_code
end

# reset the session on login, otherwise the session expires after 14 days
# and logouts crash because there is no session data (SAML_UID) to logout with
# This may need to change if we want to preserve check data over a login
# https://stackoverflow.com/questions/4812813/rails-login-reset-session
#
# Some docs suggest that devise maybe doing this behind the scenes, so
# this might be an investigation if changing this doesn't work.
reset_session
# Portal has checked that we have the correct role, so we can just sign in
sign_in_and_redirect provider, event: :authentication
end
Expand Down

0 comments on commit 4671314

Please sign in to comment.