Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1190: Welsh CW5 form #1039

Merged
merged 3 commits into from
Nov 2, 2023
Merged

EL-1190: Welsh CW5 form #1039

merged 3 commits into from
Nov 2, 2023

Conversation

MazOneTwoOne
Copy link
Contributor

Jira ticket

What changed and why

  • Enable CCQ to populate a Welsh CW5 form

Guidance to review

N/A

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review October 27, 2023 11:01
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner October 27, 2023 11:01
@MazOneTwoOne MazOneTwoOne changed the title EL-1190: Welsh CW5 formmappings and tests EL-1190: Welsh CW5 form Oct 27, 2023
@MazOneTwoOne MazOneTwoOne added the UAT Keep PR open to keep ephemeral UAT URL alive label Oct 31, 2023
@MazOneTwoOne MazOneTwoOne merged commit 82d70de into main Nov 2, 2023
11 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1190-cw5-welsh branch November 2, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-laa patrick-laa patrick-laa approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MazOneTwoOne @patrick-laa