Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El 1238: Step 3 disable maintenance mode #1072

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

patrick-laa
Copy link
Contributor

Jira ticket

What changed and why

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@patrick-laa patrick-laa changed the base branch from main to el-1238-b-hostnames November 6, 2023 10:51
@patrick-laa patrick-laa marked this pull request as ready for review November 6, 2023 10:52
@patrick-laa patrick-laa requested a review from a team as a code owner November 6, 2023 10:52
Base automatically changed from el-1238-b-hostnames to main November 6, 2023 11:15
@patrick-laa patrick-laa merged commit 37f666e into main Nov 6, 2023
11 checks passed
@patrick-laa patrick-laa deleted the EL-1238-c-disable-maintenance-mode branch November 6, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants