Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1695: Upgrade Ruby to 3.3.4 #1527

Merged
merged 4 commits into from
Sep 5, 2024
Merged

EL-1695: Upgrade Ruby to 3.3.4 #1527

merged 4 commits into from
Sep 5, 2024

Conversation

HettieS
Copy link
Contributor

@HettieS HettieS commented Sep 4, 2024

Jira ticket

What changed and why

Upgrade Ruby

Guidance to review

Coordinate the merge of this with the corresponding CFE update - might break end to end tests.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@HettieS HettieS requested a review from a team as a code owner September 4, 2024 16:52
Copy link
Contributor

@willc-work willc-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When we are recording the puppeteer process is confluence we should add a bit abut needing to do the same thing with the branch re:browser docker image builds.

i.e what you have done here:
.github/workflows/browser_tools_docker_image.yml

@HettieS HettieS merged commit 735bc19 into main Sep 5, 2024
12 checks passed
@HettieS HettieS deleted the EL-1695-upgrade-ruby branch September 5, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants