Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1726: Gajira part 4 #1576

Merged
merged 3 commits into from
Oct 4, 2024
Merged

EL-1726: Gajira part 4 #1576

merged 3 commits into from
Oct 4, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

Jira ticket

What changed and why

  • remove process job and use PR variables as they are

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@willc-work
Copy link
Contributor

the latest run of this on a dependabot is failing. because of:
Please specify JIRA_BASE_URL env
I am not sure that this PR fixes that issue.

@MazOneTwoOne
Copy link
Contributor Author

the latest run of this on a dependabot is failing. because of: Please specify JIRA_BASE_URL env I am not sure that this PR fixes that issue.

There was a separate issue with dependabot accessing GitHub Actions secrets. I've now added the JIRA secrets to the dependabot secrets workspace.

I've re-run a dependabot create pull request and it can log in correctly. Hopefully when I merge this PR, I can get the JIRA ticket to populate

@MazOneTwoOne MazOneTwoOne merged commit bf16568 into main Oct 4, 2024
12 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1726-gajira-part-4 branch October 4, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants