generated from ministryofjustice/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EL-1756: Create new field in the completed user journeys table to record EE result #1591
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
db/migrate/20241009105601_ammened_completed_user_journey_for_early_result_type.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class AmmenedCompletedUserJourneyForEarlyResultType < ActiveRecord::Migration[7.1] | ||
def change | ||
change_table :completed_user_journeys, bulk: true do |t| | ||
t.column :early_result_type, :string, null: true | ||
t.change_null :main_dwelling_owned, true | ||
t.change_null :vehicle_owned, true | ||
t.change_null :smod_assets, true | ||
t.change_null :capital_contribution, true | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've got a typo here in the class name - but on another point, normally with migration file naming, the standard is to use the present tense, and use words like 'add', 'create', 'remove' etc (you can take a look at the older migrations for some good examples - something like AddEarlyResultTypeToCompletedUserJourneys)
Also you are probably already aware of this but just in case - to generate these files you can run some commands, which give you a nice file template to work with i.e. rails generate migration ChangeCompletedUserJourneys.
Other than the naming, looks good!